Ensure operations that are unsafe during instance initialization raise errors #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxbro
reviewed
Sep 15, 2023
jbednar
reviewed
Sep 15, 2023
|
I quickly tried that and found a few places where we run
That suggests that it'd be worth it but would break too much code, it's likely we need to go through a deprecation period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are finding that some users do not correctly call
super().__init__()at all or perform actions that are not safe before they call it. To guide more users to the correct behavior and avoid undefined/weird behavior this PR adds some validations and errors to certain methods on the.paramnamespace.